Skip to content

Update api.spec.ts - #3316

Open
rudrakshtank wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
rudrakshtank:issue3315
Open

Update api.spec.ts#3316
rudrakshtank wants to merge 1 commit into
Priyanshu-byte-coder:mainfrom
rudrakshtank:issue3315

Conversation

@rudrakshtank

Copy link
Copy Markdown
Contributor

Summary

Closes #3315


Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that changes existing behavior)
  • 📝 Documentation update
  • ♻️ Refactor / code cleanup (no functional change)
  • ⚡ Performance improvement
  • 🔒 Security fix
  • 🧪 Tests only

Checklist

  • Linked the related issue above
  • Self-reviewed my own diff
  • No unnecessary console.log, debug code, or commented-out blocks
  • npm run lint passes locally
  • No TypeScript errors (npm run type-check)
  • Added or updated tests where applicable
  • Updated documentation / comments if behavior changed

@github-actions github-actions Bot added gssoc26 GSSoC 2026 contribution type:testing GSSoC type bonus: tests (+10 pts) labels Jul 31, 2026
@github-actions

Copy link
Copy Markdown

GSSoC Label Checklist 🏷️

@Priyanshu-byte-coder — please apply the appropriate labels before merging:

Difficulty (pick one):

  • level:beginner — 20 pts
  • level:intermediate — 35 pts
  • level:advanced — 55 pts
  • level:critical — 80 pts

Quality (optional):

  • quality:clean — ×1.2 multiplier
  • quality:exceptional — ×1.5 multiplier

Validation (required to score):

  • gssoc:approved — counts for points
  • gssoc:invalid / gssoc:spam / gssoc:ai-slop — does not score

Type labels (type:*) are auto-detected from files and title. Review and adjust if needed.
Points formula: (difficulty × quality_multiplier) + type_bonus

@Priyanshu-byte-coder

Copy link
Copy Markdown
Owner

What does the salt addition fix? As far as I can tell it's a no-op.

In this version of next-auth, JWTEncodeParams.salt is documented as: "When no salt is passed, we assume this is a session token." Since "next-auth.session-token" is exactly that default, passing it explicitly produces the same token as omitting it. The visual-regression suite encodes a session cookie the same way without salt and authenticates fine.

If it's fixing an actual failure you hit, I'd like to merge it — just add a line to the description saying what broke, because the diff doesn't show it. If it's defensive explicitness, that's a fair argument too, but say so.

The trailing-newline fix at the end of the file is a straightforward improvement either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc26 GSSoC 2026 contribution type:testing GSSoC type bonus: tests (+10 pts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fix authenticated API tests failing due to missing NextAuth HKDF salt

2 participants